Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_ExternalAHRS: Populate Microstrain7 orientation from filter #26131

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Feb 2, 2024

Purpose

  • Populating AHRS orientation from IMU was not correct, this should be populated by the full navigation filter orientation packet.
  • This requires users to turn on the orientation output on the filter (WIKI needed for which channels to enable in SensorConnect anyways)
  • I would like this backported to 4.5 as it is a bug to use IMU orientation for EARHS instead of the navigation solution

Testing

This needs testing before merge and a comment in the method on what quaternion order the Microstrain packet is in. I assume it's the same as the other packet, but would like to verify on hardware before merge.

./Tools/autotest/autotest.py build.Plane test.Plane.MicroStrainEAHRS7

FYI @CraigElder

@Ryanf55 Ryanf55 force-pushed the microstrain7-use-filter-quaternion branch from ba40c81 to 39fe897 Compare February 4, 2024 04:03
@Ryanf55 Ryanf55 force-pushed the microstrain7-use-filter-quaternion branch from 39fe897 to 079c1a7 Compare February 24, 2024 17:57
* Populating AHRS orientation from IMU was not correct

Signed-off-by: Ryan Friedman <[email protected]>
* This replaces IMU orientation
* Fixed some usage docs

Signed-off-by: Ryan Friedman <[email protected]>
@Ryanf55 Ryanf55 force-pushed the microstrain7-use-filter-quaternion branch from 079c1a7 to e0b7b63 Compare February 25, 2024 20:18
@Ryanf55 Ryanf55 marked this pull request as ready for review February 25, 2024 20:18
@tridge
Copy link
Contributor

tridge commented Mar 13, 2024

@Ryanf55 does this need more testing?

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Mar 14, 2024

Testing complete. I'm bundling the wiki changes with a bunch of other things for MicroStrain. I'll make sure it gets in by the time 4.5 is officially out the door.

@tridge tridge merged commit 41fc3a8 into ArduPilot:master Mar 15, 2024
92 checks passed
@Hwurzburg
Copy link
Collaborator

@Ryanf55 have you done the required wiki changes you mention?

@Ryanf55 Ryanf55 deleted the microstrain7-use-filter-quaternion branch May 11, 2024 00:46
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented May 11, 2024

@Ryanf55 have you done the required wiki changes you mention?

Yep! Everything is fine for the MicroStrain for now, just need some more flight tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 4.5.0-beta4
Development

Successfully merging this pull request may close these issues.

4 participants